Skip to content

Update Valiance Clan Plugin to 1.1.3#12380

Open
Sicryption wants to merge 1 commit into
runelite:masterfrom
Sicryption:valiance-plugin
Open

Update Valiance Clan Plugin to 1.1.3#12380
Sicryption wants to merge 1 commit into
runelite:masterfrom
Sicryption:valiance-plugin

Conversation

@Sicryption
Copy link
Copy Markdown
Contributor

No description provided.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jun 3, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jun 3, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jun 6, 2026

  • your build in runelite-plugin.properties should be standard
  • use of client.menuAction is not allowed

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 6, 2026
@Sicryption
Copy link
Copy Markdown
Contributor Author

Sicryption commented Jun 6, 2026

  • your build in runelite-plugin.properties should be standard

Will make this change

* use of client.menuAction is not allowed

This must be a new ruling. I'll look what other plugins are doing for taking Collection Log data now.

Edit: Looks like temple is still using client.menuAction. Any suggestions of plugins with new behavior for this?

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 6, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jun 6, 2026

  • use of client.menuAction is not allowed

this may actually be ok, although if there is a way to accomplish whatever you're doing without menuAction please let me know

@Sicryption
Copy link
Copy Markdown
Contributor Author

  • use of client.menuAction is not allowed

this may actually be ok, although if there is a way to accomplish whatever you're doing without menuAction please let me know

When opening the collection log, only the items which are on the current visible menu are able to be grabbed. Clicking the search button loads the data for all items regardless of page. So, what we are doing here is creating a fake search button click when the Collection Log opens, in order to load all of the item data.

Temple's plugin has a button you click on to sync it where as this plugin does it once the Collection log loads, without user input. We can add a button to map it to if that feels more correct. Otherwise, we'll just be asking our users to click the search button which is a little jank but we can live with.

@Sicryption
Copy link
Copy Markdown
Contributor Author

Accidentally rebased off an old master causing the above issue. Didn't need to rebase at all. Ooops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants