Update Valiance Clan Plugin to 1.1.3#12380
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Will make this change
This must be a new ruling. I'll look what other plugins are doing for taking Collection Log data now. Edit: Looks like temple is still using client.menuAction. Any suggestions of plugins with new behavior for this? |
this may actually be ok, although if there is a way to accomplish whatever you're doing without menuAction please let me know |
When opening the collection log, only the items which are on the current visible menu are able to be grabbed. Clicking the search button loads the data for all items regardless of page. So, what we are doing here is creating a fake search button click when the Collection Log opens, in order to load all of the item data. Temple's plugin has a button you click on to sync it where as this plugin does it once the Collection log loads, without user input. We can add a button to map it to if that feels more correct. Otherwise, we'll just be asking our users to click the search button which is a little jank but we can live with. |
59905a8 to
c0a4799
Compare
c0a4799 to
b887f0d
Compare
|
Accidentally rebased off an old master causing the above issue. Didn't need to rebase at all. Ooops |
No description provided.